Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1cb95395 authored by Axel Lin's avatar Axel Lin Committed by Linus Walleij
Browse files

pinctrl: rockchip: Simplify for loop iteration 



Just return once a match found makes the code simpler and shorter.

Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 1ede12d4

drivers/pinctrl/pinctrl-rockchip.c

+6 −15
Original line number Diff line number Diff line
@@ -167,18 +167,14 @@ static const inline struct rockchip_pin_group *pinctrl_name_to_group( 
					const struct rockchip_pinctrl *info,

					const char *name)

{

	const struct rockchip_pin_group *grp = NULL;

	int i;



	for (i = 0; i < info->ngroups; i++) {

		if (strcmp(info->groups[i].name, name))

			continue;



		grp = &info->groups[i];

		break;

		if (!strcmp(info->groups[i].name, name))

			return &info->groups[i];

	}



	return grp;

	return NULL;

}



/*
@@ -204,17 +200,12 @@ static struct rockchip_pin_bank *bank_num_to_bank( 
	struct rockchip_pin_bank *b = info->ctrl->pin_banks;

	int i;



	for (i = 0; i < info->ctrl->nr_banks; i++) {

	for (i = 0; i < info->ctrl->nr_banks; i++, b++) {

		if (b->bank_num == num)

			break;



		b++;

			return b;

	}



	if (b->bank_num != num)

	return ERR_PTR(-EINVAL);



	return b;

}



/*