Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1c4f0ef8 authored by Don Skidmore's avatar Don Skidmore Committed by David S. Miller
Browse files

ixgbe: cleanup ethtool autoneg input 



The way we were setting autoneg via ethtool was inconstant with that
of our other drivers.  It will change the following:

If autoneg is off:
>ethtool -a eth0
Pause parameters for eth0:

Autonegotiate:  off
RX:             off
TX:             off

Before:
>ethtool -A eth0 autoneg on
>ethtool -a eth0
Pause parameters for eth0:

Autonegotiate:  off
RX:             off
TX:             off

Now:
>ethtool -A eth0 autoneg on
>ethtool -a eth0
Pause parameters for eth0:

Autonegotiate:  on
RX:             on
TX:             on

Signed-off-by: default avatarDon Skidmore <donald.c.skidmore@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3203df04

drivers/net/ixgbe/ixgbe_ethtool.c

+1 −1
Original line number Diff line number Diff line
@@ -365,7 +365,7 @@ static int ixgbe_set_pauseparam(struct net_device *netdev, 
	else

		fc.disable_fc_autoneg = false;



	if (pause->rx_pause && pause->tx_pause)

	if ((pause->rx_pause && pause->tx_pause) || pause->autoneg)

		fc.requested_mode = ixgbe_fc_full;

	else if (pause->rx_pause && !pause->tx_pause)

		fc.requested_mode = ixgbe_fc_rx_pause;