Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1c4db8e8 authored by Phil Sutter's avatar Phil Sutter Committed by Ralf Baechle
Browse files

MIPS: RB532: Simplify dev3 init 



As rb532_dev3_ctl_res is not used by any platform device, it can be dropped
when not used for holding the physical address of the device 3 controller.

Also a size of one byte should suffice when ioremapping the physical
address mentioned above, as only a single byte is being read from and
written to it.

Signed-off-by: default avatarPhil Sutter <n0-1@freewrt.org>
Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
parent 4ca3803f

arch/mips/rb532/devices.c

+2 −12
Original line number Diff line number Diff line
@@ -63,13 +63,6 @@ unsigned char get_latch_u5(void) 
}

EXPORT_SYMBOL(get_latch_u5);



static struct resource rb532_dev3_ctl_res[] = {

	{

		.name	= "dev3_ctl",

		.flags	= IORESOURCE_MEM,

	}

};



static struct resource korina_dev0_res[] = {

	{

		.name = "korina_regs",
@@ -342,11 +335,8 @@ static int __init plat_setup_devices(void) 
	nand_slot0_res[0].start = readl(IDT434_REG_BASE + DEV2BASE);

	nand_slot0_res[0].end = nand_slot0_res[0].start + 0x1000;



	/* Read the third (multi purpose) resources from the DC */

	rb532_dev3_ctl_res[0].start = readl(IDT434_REG_BASE + DEV3BASE);

	rb532_dev3_ctl_res[0].end = rb532_dev3_ctl_res[0].start + 0x1000;



	dev3.base = ioremap_nocache(rb532_dev3_ctl_res[0].start, 0x1000);

	/* Read and map device controller 3 */

	dev3.base = ioremap_nocache(readl(IDT434_REG_BASE + DEV3BASE), 1);



	if (!dev3.base) {

		printk(KERN_ERR "rb532: cannot remap device controller 3\n");