Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1c2e92c6 authored by Ian Maund's avatar Ian Maund
Browse files

checkpatch.pl: Add additional granularity to malformed commit errors 



Commit-Ids are expected to be 12 to 40 characters, followed by a
description enclosed by parenthesis. The current error message only
mentions the length requirement, causing confusion when a commit-Id is
formatted properly but the description is not inside parenthesis.

Change-Id: If4c5a9c197146de9ada7c618a1cfff38514e611c
Signed-off-by: default avatarIan Maund <imaund@codeaurora.org>
parent fd854d74

scripts/checkpatch.pl

+1 −1
Original line number Diff line number Diff line
@@ -2318,7 +2318,7 @@ sub process { 
			my $desc = 'commit description';

		        ($id, $desc) = git_commit_info($orig_commit, $id, $desc);

			ERROR("GIT_COMMIT_ID",

			      "Please use 12 or more chars for the git commit ID like: '${init_char}ommit $id (\"$desc\")'\n" . $herecurr);

			      "Please use 12 or more chars for the git commit ID and enclose the descritpion in parenthesis like: '${init_char}ommit $id (\"$desc\")'\n" . $herecurr);

		}



# Check for added, moved or deleted files