Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1ba80c9e authored by Jingoo Han's avatar Jingoo Han Committed by Brian Norris
Browse files

mtd: dataflash: remove unnecessary spi_set_drvdata() 



The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: default avatarJingoo Han <jg1.han@samsung.com>
Signed-off-by: default avatarBrian Norris <computersforpeace@gmail.com>
parent afc62baf

drivers/mtd/devices/mtd_dataflash.c

+1 −4
Original line number Diff line number Diff line
@@ -669,7 +669,6 @@ static int add_dataflash_otp(struct spi_device *spi, char *name, int nr_pages, 
	if (!err)

		return 0;



	spi_set_drvdata(spi, NULL);

	kfree(priv);

	return err;

}
@@ -899,10 +898,8 @@ static int dataflash_remove(struct spi_device *spi) 
	pr_debug("%s: remove\n", dev_name(&spi->dev));



	status = mtd_device_unregister(&flash->mtd);

	if (status == 0) {

		spi_set_drvdata(spi, NULL);

	if (status == 0)

		kfree(flash);

	}

	return status;

}