Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1b8b9750 authored by Artem Bityutskiy's avatar Artem Bityutskiy Committed by Theodore Ts'o
Browse files

ext4: do not mark superblock as dirty unnecessarily 



Commit a0375156 cleaned up superblock
dirtying handling, but missed one place. This patch does what was
intended: if we have the journal, then we update the superblock
through the journal rather than doing this directly.

Signed-off-by: default avatarArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
parent 73355192

fs/ext4/inode.c

+1 −3
Original line number Diff line number Diff line
@@ -3935,10 +3935,8 @@ static int ext4_do_update_inode(handle_t *handle, 
			ext4_update_dynamic_rev(sb);

			EXT4_SET_RO_COMPAT_FEATURE(sb,

					EXT4_FEATURE_RO_COMPAT_LARGE_FILE);

			sb->s_dirt = 1;

			ext4_handle_sync(handle);

			err = ext4_handle_dirty_metadata(handle, NULL,

					EXT4_SB(sb)->s_sbh);

			err = ext4_handle_dirty_super(handle, sb);

		}

	}

	raw_inode->i_generation = cpu_to_le32(inode->i_generation);