Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1a590cab authored by Vikas Chaudhary's avatar Vikas Chaudhary Committed by James Bottomley
Browse files

[SCSI] iscsi_transport: Added error status code for ping comp event 



Defined error codes for ping completion status.

This patch take care of Mike Christie's commets

Signed-off-by: default avatarVikas Chaudhary <vikas.chaudhary@qlogic.com>
Reviewed-by: default avatarMike Christie <michaelc@cs.wisc.edu>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent e16d166e

drivers/scsi/qla4xxx/ql4_isr.c

+2 −2
Original line number Diff line number Diff line
@@ -431,9 +431,9 @@ static void qla4xxx_mbox_status_entry(struct scsi_qla_host *ha, 
				  mbox_sts_entry->out_mbox[6]));



		if (mbox_sts_entry->out_mbox[0] == MBOX_STS_COMMAND_COMPLETE)

			status = QLA_SUCCESS;

			status = ISCSI_PING_SUCCESS;

		else

			status = QLA_ERROR;

			status = mbox_sts_entry->out_mbox[6];



		data_size = sizeof(mbox_sts_entry->out_mbox);

include/scsi/iscsi_if.h

+16 −1
Original line number Diff line number Diff line
@@ -261,7 +261,8 @@ struct iscsi_uevent { 
		} host_event;

		struct msg_ping_comp {

			uint32_t        host_no;

			uint32_t        status;

			uint32_t        status; /* enum

						 * iscsi_ping_status_code */

			uint32_t	pid;	/* unique ping id associated

						   with each ping request */

			uint32_t        data_size;
@@ -483,6 +484,20 @@ enum iscsi_port_state { 
	ISCSI_PORT_STATE_UP		= 0x2,

};



/* iSCSI PING status/error code */

enum iscsi_ping_status_code {

	ISCSI_PING_SUCCESS			= 0,

	ISCSI_PING_FW_DISABLED			= 0x1,

	ISCSI_PING_IPADDR_INVALID		= 0x2,

	ISCSI_PING_LINKLOCAL_IPV6_ADDR_INVALID	= 0x3,

	ISCSI_PING_TIMEOUT			= 0x4,

	ISCSI_PING_INVALID_DEST_ADDR		= 0x5,

	ISCSI_PING_OVERSIZE_PACKET		= 0x6,

	ISCSI_PING_ICMP_ERROR			= 0x7,

	ISCSI_PING_MAX_REQ_EXCEEDED		= 0x8,

	ISCSI_PING_NO_ARP_RECEIVED		= 0x9,

};



#define iscsi_ptr(_handle) ((void*)(unsigned long)_handle)

#define iscsi_handle(_ptr) ((uint64_t)(unsigned long)_ptr)