Commit 1a06a52e authored May 17, 2007 by Rolf Eike Beer Committed by Linus Torvalds May 18, 2007

Fix roundup_pow_of_two(1)

1 is a power of two, therefore roundup_pow_of_two(1) should return 1. It does
in case the argument is a variable but in case it's a constant it behaves
wrong and returns 0. Probably nobody ever did it so this was never noticed.

Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 18963c01

include/linux/log2.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -159,7 +159,7 @@ unsigned long __roundup_pow_of_two(unsigned long n)
		#define roundup_pow_of_two(n) \
		( \
		__builtin_constant_p(n) ? ( \
		(n == 1) ? 0 : \
		(n == 1) ? 1 : \
		(1UL << (ilog2((n) - 1) + 1)) \
		) : \
		__roundup_pow_of_two(n) \