Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1a012d58 authored by Sasha Levin's avatar Sasha Levin
Browse files

ALSA: hda - fix use-after-free after module unload 



[ Upstream commit ab58d8cc870ef3f0771c197700441936898d1f1d ]

register_vga_switcheroo() sets the PM ops from the hda structure which
is freed later in azx_free. Make sure that these ops are cleared.

Caught by KASAN, initially noticed due to a general protection fault.

Fixes: 246efa4a ("snd/hda: add runtime suspend/resume on optimus support (v4)")
Signed-off-by: default avatarPeter Wu <peter@lekensteyn.nl>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarSasha Levin <alexander.levin@verizon.com>
parent 943e282c

sound/pci/hda/hda_intel.c

+3 −1
Original line number Diff line number Diff line
@@ -1119,8 +1119,10 @@ static int azx_free(struct azx *chip) 
	if (use_vga_switcheroo(hda)) {

		if (chip->disabled && chip->bus)

			snd_hda_unlock_devices(chip->bus);

		if (hda->vga_switcheroo_registered)

		if (hda->vga_switcheroo_registered) {

			vga_switcheroo_unregister_client(chip->pci);

			vga_switcheroo_fini_domain_pm_ops(chip->card->dev);

		}

	}



	if (chip->initialized) {