Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 18b631f8 authored by J. Bruce Fields's avatar J. Bruce Fields
Browse files

nfsd: fix offset printk's in nfsd3 read/write 

Thanks to dysbr01@ca.com for noticing that the debugging printk in
the v3 write procedure can print >2GB offsets as negative numbers:
	https://bugzilla.kernel.org/show_bug.cgi?id=23342



Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
parent e203d506

fs/nfsd/nfs3proc.c

+4 −4
Original line number Diff line number Diff line
@@ -151,10 +151,10 @@ nfsd3_proc_read(struct svc_rqst *rqstp, struct nfsd3_readargs *argp, 
	__be32	nfserr;

	u32	max_blocksize = svc_max_payload(rqstp);



	dprintk("nfsd: READ(3) %s %lu bytes at %lu\n",

	dprintk("nfsd: READ(3) %s %lu bytes at %Lu\n",

				SVCFH_fmt(&argp->fh),

				(unsigned long) argp->count,

				(unsigned long) argp->offset);

				(unsigned long long) argp->offset);



	/* Obtain buffer pointer for payload.

	 * 1 (status) + 22 (post_op_attr) + 1 (count) + 1 (eof)
@@ -191,10 +191,10 @@ nfsd3_proc_write(struct svc_rqst *rqstp, struct nfsd3_writeargs *argp, 
	__be32	nfserr;

	unsigned long cnt = argp->len;



	dprintk("nfsd: WRITE(3)    %s %d bytes at %ld%s\n",

	dprintk("nfsd: WRITE(3)    %s %d bytes at %Lu%s\n",

				SVCFH_fmt(&argp->fh),

				argp->len,

				(unsigned long) argp->offset,

				(unsigned long long) argp->offset,

				argp->stable? " stable" : "");



	fh_copy(&resp->fh, &argp->fh);