Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 189248d8 authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds
Browse files

checkpatch: check for if's with unnecessary parentheses 



If statements don't need multiple parentheses around tested comparisons
like "if ((foo == bar))".

An == comparison maybe a sign of an intended assignment, so emit a
slightly different message if so.

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Reviewed-by: default avatarJosh Triplett <josh@joshtriplett.org>
Cc: Manfred Spraul <manfred@colorfullife.com>
Cc: Andy Whitcroft <apw@canonical.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent c76f4cb3

scripts/checkpatch.pl

+14 −0
Original line number Original line Diff line number Diff line
@@ -3254,6 +3254,20 @@ sub process { 
			}

			}

		}

		}





# if statements using unnecessary parentheses - ie: if ((foo == bar))

		if ($^V && $^V ge 5.10.0 &&

		    $line =~ /\bif\s*((?:\(\s*){2,})/) {

			my $openparens = $1;

			my $count = $openparens =~ tr@\(@\(@;

			my $msg = "";

			if ($line =~ /\bif\s*(?:\(\s*){$count,$count}$LvalOrFunc\s*($Compare)\s*$LvalOrFunc(?:\s*\)){$count,$count}/) {

				my $comp = $4;	#Not $1 because of $LvalOrFunc

				$msg = " - maybe == should be = ?" if ($comp eq "==");

				WARN("UNNECESSARY_PARENTHESES",

				     "Unnecessary parentheses$msg\n" . $herecurr);

			}

		}



# Return of what appears to be an errno should normally be -'ve

# Return of what appears to be an errno should normally be -'ve

		if ($line =~ /^.\s*return\s*(E[A-Z]*)\s*;/) {

		if ($line =~ /^.\s*return\s*(E[A-Z]*)\s*;/) {

			my $name = $1;

			my $name = $1;