Commit 1887f517 authored Jun 24, 2006 by Herbert Valerio Riedel Committed by David Woodhouse Jun 27, 2006

[MTD] CORE mtdchar.c: fix off-by-one error in lseek()



Allow lseek(mtdchar_fd, 0, SEEK_END) to succeed, which currently fails
with EINVAL.

lseek(fd, 0, SEEK_END) should result into the same fileposition as
lseek(fd, 0, SEEK_SET) + read(fd, buf, length(fd))

Furthermore, lseek(fd, 0, SEEK_CUR) should return the current file position,
which in case of an encountered EOF should not result in EINVAL

Signed-off-by: Herbert Valerio Riedel <hvr@gnu.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>

parent 0e4ced59

drivers/mtd/mtdchar.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -78,7 +78,7 @@ static loff_t mtd_lseek (struct file *file, loff_t offset, int orig)
		return -EINVAL;
		}

		if (offset >= 0 && offset < mtd->size)
		if (offset >= 0 && offset <= mtd->size)
		return file->f_pos = offset;

		return -EINVAL;