Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1844f747 authored by Jarek Poplawski's avatar Jarek Poplawski Committed by David S. Miller
Browse files

pkt_sched: sch_drr: Fix oops in drr_change_class. 



drr_change_class lacks a check for NULL of tca[TCA_OPTIONS], so oops
is possible.

Reported-by: default avatarDenys Fedoryschenko <denys@visp.net.lb>
Signed-off-by: default avatarJarek Poplawski <jarkao2@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e92aa634

net/sched/sch_drr.c

+5 −1
Original line number Diff line number Diff line
@@ -66,11 +66,15 @@ static int drr_change_class(struct Qdisc *sch, u32 classid, u32 parentid, 
{

	struct drr_sched *q = qdisc_priv(sch);

	struct drr_class *cl = (struct drr_class *)*arg;

	struct nlattr *opt = tca[TCA_OPTIONS];

	struct nlattr *tb[TCA_DRR_MAX + 1];

	u32 quantum;

	int err;



	err = nla_parse_nested(tb, TCA_DRR_MAX, tca[TCA_OPTIONS], drr_policy);

	if (!opt)

		return -EINVAL;



	err = nla_parse_nested(tb, TCA_DRR_MAX, opt, drr_policy);

	if (err < 0)

		return err;