Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 17caf955 authored by Joseph Qi's avatar Joseph Qi Committed by Linus Torvalds
Browse files

ocfs2: add the missing return value check of ocfs2_xattr_get_clusters 



In ocfs2_xattr_value_attach_refcount(), if error occurs when calling
ocfs2_xattr_get_clusters(), it will go with unexpected behavior since
local variables p_cluster, num_clusters and ext_flags are declared without
initialization.

Signed-off-by: default avatarJoseph Qi <joseph.qi@huawei.com>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: Mark Fasheh <mfasheh@suse.com>
Acked-by: default avatarJie Liu <jeff.liu@oracle.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 4704aa30

fs/ocfs2/xattr.c

+4 −0
Original line number Diff line number Diff line
@@ -5881,6 +5881,10 @@ static int ocfs2_xattr_value_attach_refcount(struct inode *inode, 
	while (cpos < clusters) {

		ret = ocfs2_xattr_get_clusters(inode, cpos, &p_cluster,

					       &num_clusters, el, &ext_flags);

		if (ret) {

			mlog_errno(ret);

			break;

		}



		cpos += num_clusters;

		if ((ext_flags & OCFS2_EXT_REFCOUNTED))