Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 17169329 authored by Jouni Malinen's avatar Jouni Malinen Committed by Kalle Valo
Browse files

ath6kl: Fix endpoint_stats debugfs buffer length calculation 



The previous version did not really make much sense and the theoretical
maximum length would be a bit longer. Calculate the length more
accurately. In addition, there is no need to clear the buffer, so use
kmalloc instead of kzalloc. For bonus points, add the forgotten
cred_rpt_from_other value to the file.

Reported-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarJouni Malinen <jouni@qca.qualcomm.com>
Signed-off-by: default avatarKalle Valo <kvalo@qca.qualcomm.com>
parent 17380859

drivers/net/wireless/ath/ath6kl/debug.c

+4 −2
Original line number Diff line number Diff line
@@ -624,8 +624,9 @@ static ssize_t ath6kl_endpoint_stats_read(struct file *file, 
	unsigned int buf_len, len = 0;

	ssize_t ret_cnt;



	buf_len = 1000 + ENDPOINT_MAX * 100;

	buf = kzalloc(buf_len, GFP_KERNEL);

	buf_len = sizeof(struct htc_endpoint_stats) / sizeof(u32) *

		(25 + ENDPOINT_MAX * 11);

	buf = kmalloc(buf_len, GFP_KERNEL);

	if (!buf)

		return -ENOMEM;
@@ -640,6 +641,7 @@ static ssize_t ath6kl_endpoint_stats_read(struct file *file, 
	EPSTAT(tx_dropped);

	EPSTAT(tx_cred_rpt);

	EPSTAT(cred_rpt_from_rx);

	EPSTAT(cred_rpt_from_other);

	EPSTAT(cred_rpt_ep0);

	EPSTAT(cred_from_rx);

	EPSTAT(cred_from_other);