Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 165a3c7d authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Greg Kroah-Hartman
Browse files

eeprom: at24: check at24_read/write arguments 



commit d9bcd462daf34aebb8de9ad7f76de0198bb5a0f0 upstream.

So far we completely rely on the caller to provide valid arguments.
To be on the safe side perform an own sanity check.

Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: default avatarBartosz Golaszewski <brgl@bgdev.pl>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 092b0115

drivers/misc/eeprom/at24.c

+6 −0
Original line number Diff line number Diff line
@@ -274,6 +274,9 @@ static ssize_t at24_read(struct at24_data *at24, 
	if (unlikely(!count))

		return count;



	if (off + count > at24->chip.byte_len)

		return -EINVAL;



	/*

	 * Read data from chip, protecting against concurrent updates

	 * from this host, but not from other I2C masters.
@@ -328,6 +331,9 @@ static ssize_t at24_eeprom_write(struct at24_data *at24, const char *buf, 
	unsigned long timeout, write_time;

	unsigned next_page;



	if (offset + count > at24->chip.byte_len)

		return -EINVAL;



	/* Get corresponding I2C address and adjust offset */

	client = at24_translate_offset(at24, &offset);