Commit 15ac0778 authored Mar 10, 2013 by Kalle Valo

ath6kl: remove false check from ath6kl_rx()



Dan found a check from ath6kl_rx() which doesn't make any sense at all:

"  1327          if (status || !(skb->data + HTC_HDR_LENGTH)) {
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^
skb->data is a pointer.  This pointer math is always going to be false.
Should it be testing "packet->act_len < HTC_HDR_LENGTH" or something?"

I don't know what the check really was supposed to do, but I think Dan's guess
is right. Fix it accordingly.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>

parent 99089ab7

drivers/net/wireless/ath/ath6kl/txrx.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1327,7 +1327,7 @@ void ath6kl_rx(struct htc_target target, struct htc_packet packet)
		__func__, ar, ept, skb, packet->buf,
		packet->act_len, status);

		if (status \|\| !(skb->data + HTC_HDR_LENGTH)) {
		if (status \|\| packet->act_len < HTC_HDR_LENGTH) {
		dev_kfree_skb(skb);
		return;
		}