Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 158132c9 authored by Brijesh Singh's avatar Brijesh Singh Committed by Artem Bityutskiy
Browse files

UBI: improve delete-compatible volumes handling 



When a delete-compatible volume is found, it is first added to the
'corr' list, which contains "corrupted" PEBs which should be erased,
and then it is added to the used volumes tree. However, the second
step should not be done. This does not cause problems in practice,
because we never access delete-compattible volumes, but it is still
not the right thing to do.

[Artem: amended the commit message and few prints]

Signed-off-by: default avatarBrijesh Singh <brijesh.s.singh@gmail.com>
Signed-off-by: default avatarArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
parent f5d5b1f8

drivers/mtd/ubi/scan.c

+2 −2
Original line number Diff line number Diff line
@@ -842,11 +842,11 @@ static int process_eb(struct ubi_device *ubi, struct ubi_scan_info *si, 
		switch (vidh->compat) {

		case UBI_COMPAT_DELETE:

			ubi_msg("\"delete\" compatible internal volume %d:%d"

				" found, remove it", vol_id, lnum);

				" found, will remove it", vol_id, lnum);

			err = add_to_list(si, pnum, ec, &si->corr);

			if (err)

				return err;

			break;

			return 0;



		case UBI_COMPAT_RO:

			ubi_msg("read-only compatible internal volume %d:%d"