Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 15720e56 authored by Felipe Balbi's avatar Felipe Balbi Committed by Sasha Levin
Browse files

usb: dwc3: gadget: don't clear EP_BUSY too early 



[ Upstream commit e18b7975c885bc3a938b9a76daf32957ea0235fa ]

In case of non-Isochronous transfers, we don't
want to clear DWC3_EP_BUSY flag until XferComplete
event. That's because XferInProgress was only enabled
so we can recycle TRBs and usb_requests quicker, but
there are still other pending requests being transferred.

In order to make sure we don't allow for another StartTransfer
command while the HW is still processing other transfers,
we must keep DWC3_EP_BUSY flag set and this what this patch
does.

Fixes: f3af3651 (usb: dwc3: gadget: always enable IOC on
	bulk/interrupt transfers)
Cc: <stable@vger.kernel.org> # v3.15+
Reported-by: default avatarsundeep subbaraya <sundeep.lkml@gmail.com>
Tested-by: default avatarsundeep subbaraya <sundeep.lkml@gmail.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>

Signed-off-by: default avatarSasha Levin <sasha.levin@oracle.com>
parent a927cb7a

drivers/usb/dwc3/gadget.c

+5 −1
Original line number Diff line number Diff line
@@ -1903,12 +1903,16 @@ static void dwc3_endpoint_transfer_complete(struct dwc3 *dwc, 
{

	unsigned		status = 0;

	int			clean_busy;

	u32			is_xfer_complete;



	is_xfer_complete = (event->endpoint_event == DWC3_DEPEVT_XFERCOMPLETE);



	if (event->status & DEPEVT_STATUS_BUSERR)

		status = -ECONNRESET;



	clean_busy = dwc3_cleanup_done_reqs(dwc, dep, event, status);

	if (clean_busy)

	if (clean_busy && (is_xfer_complete ||

				usb_endpoint_xfer_isoc(dep->endpoint.desc)))

		dep->flags &= ~DWC3_EP_BUSY;



	/*