Commit 14e0a193 authored Oct 03, 2006 by Kirill Smelkov Committed by Linus Torvalds Oct 03, 2006

[PATCH] ide: fix revision comparison in ide_in_drive_list



Fix ide_in_drive_list: drive_table->id_firmware should be searched *in*
id->fw_rev, not vice versa.

Signed-off-by: Kirill Smelkov <kirr@mns.spb.ru>
Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent f3d5b34c

drivers/ide/ide-dma.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -145,7 +145,7 @@ int ide_in_drive_list(struct hd_driveid id, const struct drive_list_entry driv
		{
		for ( ; drive_table->id_model ; drive_table++)
		if ((!strcmp(drive_table->id_model, id->model)) &&
		((strstr(drive_table->id_firmware, id->fw_rev)) \|\|
		((strstr(id->fw_rev, drive_table->id_firmware)) \|\|
		(!strcmp(drive_table->id_firmware, "ALL"))))
		return 1;
		return 0;