Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1499d9fa authored by Daniel Drake's avatar Daniel Drake Committed by John W. Linville
Browse files

mwifiex: don't drop carrier flag over suspend 

If the system suspends with mwifiex wifi powered on, and is then woken
by an ICMP ping packet, the ping response is discarded by the kernel
because the kernel incorrectly thinks there is no carrier.

I can't see any valid reason to want to report loss of carrier here,
so remove the offending code.

Fixes http://dev.laptop.org/ticket/12554



Signed-off-by: default avatarDaniel Drake <dsd@laptop.org>
Acked-by: default avatarBing Zhao <bzhao@marvell.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent b53cf458

drivers/net/wireless/mwifiex/pcie.c

+1 −9
Original line number Diff line number Diff line
@@ -171,7 +171,7 @@ static int mwifiex_pcie_suspend(struct pci_dev *pdev, pm_message_t state) 
{

	struct mwifiex_adapter *adapter;

	struct pcie_service_card *card;

	int hs_actived, i;

	int hs_actived;



	if (pdev) {

		card = (struct pcie_service_card *) pci_get_drvdata(pdev);
@@ -191,9 +191,6 @@ static int mwifiex_pcie_suspend(struct pci_dev *pdev, pm_message_t state) 
	/* Indicate device suspended */

	adapter->is_suspended = true;



	for (i = 0; i < adapter->priv_num; i++)

		netif_carrier_off(adapter->priv[i]->netdev);



	return 0;

}
@@ -209,7 +206,6 @@ static int mwifiex_pcie_resume(struct pci_dev *pdev) 
{

	struct mwifiex_adapter *adapter;

	struct pcie_service_card *card;

	int i;



	if (pdev) {

		card = (struct pcie_service_card *) pci_get_drvdata(pdev);
@@ -231,10 +227,6 @@ static int mwifiex_pcie_resume(struct pci_dev *pdev) 


	adapter->is_suspended = false;



	for (i = 0; i < adapter->priv_num; i++)

		if (adapter->priv[i]->media_connected)

			netif_carrier_on(adapter->priv[i]->netdev);



	mwifiex_cancel_hs(mwifiex_get_priv(adapter, MWIFIEX_BSS_ROLE_STA),

			  MWIFIEX_ASYNC_CMD);

drivers/net/wireless/mwifiex/sdio.c

+0 −9
Original line number Diff line number Diff line
@@ -161,7 +161,6 @@ static int mwifiex_sdio_suspend(struct device *dev) 
	struct sdio_mmc_card *card;

	struct mwifiex_adapter *adapter;

	mmc_pm_flag_t pm_flag = 0;

	int i;

	int ret = 0;



	if (func) {
@@ -198,9 +197,6 @@ static int mwifiex_sdio_suspend(struct device *dev) 
	/* Indicate device suspended */

	adapter->is_suspended = true;



	for (i = 0; i < adapter->priv_num; i++)

		netif_carrier_off(adapter->priv[i]->netdev);



	return ret;

}
@@ -220,7 +216,6 @@ static int mwifiex_sdio_resume(struct device *dev) 
	struct sdio_mmc_card *card;

	struct mwifiex_adapter *adapter;

	mmc_pm_flag_t pm_flag = 0;

	int i;



	if (func) {

		pm_flag = sdio_get_host_pm_caps(func);
@@ -243,10 +238,6 @@ static int mwifiex_sdio_resume(struct device *dev) 


	adapter->is_suspended = false;



	for (i = 0; i < adapter->priv_num; i++)

		if (adapter->priv[i]->media_connected)

			netif_carrier_on(adapter->priv[i]->netdev);



	/* Disable Host Sleep */

	mwifiex_cancel_hs(mwifiex_get_priv(adapter, MWIFIEX_BSS_ROLE_STA),

			  MWIFIEX_ASYNC_CMD);