Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1497d3ad authored by Jan Kara's avatar Jan Kara Committed by Mark Fasheh
Browse files

quota: Remove bogus 'optimization' in check_idq() and check_bdq() 



Checks like <= 0 for an unsigned type do not make much sence. The value
could be only 0 and that does not happen often enough for the check
to be worth it.

Signed-off-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarMark Fasheh <mfasheh@suse.com>
parent 12095460

fs/dquot.c

+2 −2
Original line number Diff line number Diff line
@@ -1041,7 +1041,7 @@ static inline char ignore_hardlimit(struct dquot *dquot) 
static int check_idq(struct dquot *dquot, qsize_t inodes, char *warntype)

{

	*warntype = QUOTA_NL_NOWARN;

	if (inodes <= 0 || test_bit(DQ_FAKE_B, &dquot->dq_flags))

	if (test_bit(DQ_FAKE_B, &dquot->dq_flags))

		return QUOTA_OK;



	if (dquot->dq_dqb.dqb_ihardlimit &&
@@ -1073,7 +1073,7 @@ static int check_idq(struct dquot *dquot, qsize_t inodes, char *warntype) 
static int check_bdq(struct dquot *dquot, qsize_t space, int prealloc, char *warntype)

{

	*warntype = QUOTA_NL_NOWARN;

	if (space <= 0 || test_bit(DQ_FAKE_B, &dquot->dq_flags))

	if (test_bit(DQ_FAKE_B, &dquot->dq_flags))

		return QUOTA_OK;



	if (dquot->dq_dqb.dqb_bhardlimit &&