Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1482338f authored by Randy Dunlap's avatar Randy Dunlap Committed by Linus Torvalds
Browse files

scsi: fix operator precedence warning 



Fix operator precedence warning (from sparse), which results in the
data value always being 0:

drivers/scsi/qla4xxx/ql4_mbx.c:470:66: warning: right shift by bigger than source value

Signed-off-by: default avatarRandy Dunlap <randy.dunlap@oracle.com>
Acked-by: default avatarRavi Anand <ravi.anand@qlogic.com>
Cc: David C Somayajulu <david.somayajulu@qlogic.com>
Cc: Karen Higgins <karen.higgins@qlogic.com>
Cc: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent c81eddb0

drivers/scsi/qla4xxx/ql4_mbx.c

+1 −1
Original line number Diff line number Diff line
@@ -467,7 +467,7 @@ int qla4xxx_get_fwddb_entry(struct scsi_qla_host *ha, 
	if (conn_err_detail)

		*conn_err_detail = mbox_sts[5];

	if (tcp_source_port_num)

		*tcp_source_port_num = (uint16_t) mbox_sts[6] >> 16;

		*tcp_source_port_num = (uint16_t) (mbox_sts[6] >> 16);

	if (connection_id)

		*connection_id = (uint16_t) mbox_sts[6] & 0x00FF;

	status = QLA_SUCCESS;