Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 144beb2f authored by Michael Ellerman's avatar Michael Ellerman Committed by Benjamin Herrenschmidt
Browse files

powerpc: Update comments in irqflags.h 



The comment on TRACE_ENABLE_INTS is incorrect, and appears to have
always been incorrect since the code was merged. It probably came from
an original out-of-tree patch.

Replace it with something that's correct. Also propagate the message to
RECONCILE_IRQ_STATE(), because it's potentially subtle.

Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent 4e2bf01b

arch/powerpc/include/asm/irqflags.h

+5 −3
Original line number Diff line number Diff line
@@ -32,9 +32,8 @@ 
#endif



/*

 * Most of the CPU's IRQ-state tracing is done from assembly code; we

 * have to call a C function so call a wrapper that saves all the

 * C-clobbered registers.

 * These are calls to C code, so the caller must be prepared for volatiles to

 * be clobbered.

 */

#define TRACE_ENABLE_INTS	TRACE_WITH_FRAME_BUFFER(trace_hardirqs_on)

#define TRACE_DISABLE_INTS	TRACE_WITH_FRAME_BUFFER(trace_hardirqs_off)
@@ -42,6 +41,9 @@ 
/*

 * This is used by assembly code to soft-disable interrupts first and

 * reconcile irq state.

 *

 * NB: This may call C code, so the caller must be prepared for volatiles to

 * be clobbered.

 */

#define RECONCILE_IRQ_STATE(__rA, __rB)		\

	lbz	__rA,PACASOFTIRQEN(r13);	\