Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 141aeb9f authored by Trond Myklebust's avatar Trond Myklebust
Browse files

NFSv4: Fix two unbalanced put_rpccred() issues. 

Commits 29fba38b (nfs41: lease renewal) and fc01cea9 (nfs41: sequence
operation) introduce a couple of put_rpccred() calls on credentials for
which there is no corresponding get_rpccred().

See http://bugzilla.kernel.org/show_bug.cgi?id=14249



Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent 52567b03

fs/nfs/nfs4proc.c

+0 −4
Original line number Diff line number Diff line
@@ -3065,9 +3065,6 @@ static void nfs4_renew_done(struct rpc_task *task, void *data) 
	if (time_before(clp->cl_last_renewal,timestamp))

		clp->cl_last_renewal = timestamp;

	spin_unlock(&clp->cl_lock);

	dprintk("%s calling put_rpccred on rpc_cred %p\n", __func__,

				task->tk_msg.rpc_cred);

	put_rpccred(task->tk_msg.rpc_cred);

}



static const struct rpc_call_ops nfs4_renew_ops = {
@@ -4882,7 +4879,6 @@ void nfs41_sequence_call_done(struct rpc_task *task, void *data) 
	nfs41_sequence_free_slot(clp, task->tk_msg.rpc_resp);

	dprintk("%s rpc_cred %p\n", __func__, task->tk_msg.rpc_cred);



	put_rpccred(task->tk_msg.rpc_cred);

	kfree(task->tk_msg.rpc_argp);

	kfree(task->tk_msg.rpc_resp);