Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 13cac152 authored by Lukasz Rymanowski's avatar Lukasz Rymanowski Committed by Marcel Holtmann
Browse files

Bluetooth: Fix ERTM L2CAP resend packet 



I-Frame which is going to be resend already has FCS field added and set
(if it was required). Adding additional FCS field calculated from data +
old FCS in resend function is incorrect. This patch fix that.

Issue has been found during PTS testing.

Signed-off-by: default avatarLukasz Rymanowski <lukasz.rymanowski@tieto.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent 069cb270

net/bluetooth/l2cap_core.c

+5 −3
Original line number Diff line number Diff line
@@ -1968,10 +1968,12 @@ static void l2cap_ertm_resend(struct l2cap_chan *chan) 
					   tx_skb->data + L2CAP_HDR_SIZE);

		}



		/* Update FCS */

		if (chan->fcs == L2CAP_FCS_CRC16) {

			u16 fcs = crc16(0, (u8 *) tx_skb->data, tx_skb->len);

			put_unaligned_le16(fcs, skb_put(tx_skb,

							L2CAP_FCS_SIZE));

			u16 fcs = crc16(0, (u8 *) tx_skb->data,

					tx_skb->len - L2CAP_FCS_SIZE);

			put_unaligned_le16(fcs, skb_tail_pointer(tx_skb) -

						L2CAP_FCS_SIZE);

		}



		l2cap_do_send(chan, tx_skb);