Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 13c33a09 authored by Wey-Yi Guy's avatar Wey-Yi Guy Committed by John W. Linville
Browse files

iwlwifi: add value and range define for link quality command 



Instead of hardcoding the link quality parameters inside the functions,
adding #define in iwl-commands.h to shared by different functions.
Also include the valid range for number of link quality parameters.

Signed-off-by: default avatarWey-Yi Guy <wey-yi.w.guy@intel.com>
Signed-off-by: default avatarReinette Chatre <reinette.chatre@intel.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 258c44a0

drivers/net/wireless/iwlwifi/iwl-agn-rs.c

+4 −3
Original line number Diff line number Diff line
@@ -2787,9 +2787,10 @@ static void rs_fill_link_cmd(const struct iwl_priv *priv, 
		repeat_rate--;

	}



	lq_cmd->agg_params.agg_frame_cnt_limit = 64;

	lq_cmd->agg_params.agg_dis_start_th = 3;

	lq_cmd->agg_params.agg_time_limit = cpu_to_le16(4000);

	lq_cmd->agg_params.agg_frame_cnt_limit = LINK_QUAL_AGG_FRAME_LIMIT_MAX;

	lq_cmd->agg_params.agg_dis_start_th = LINK_QUAL_AGG_DISABLE_START_DEF;

	lq_cmd->agg_params.agg_time_limit =

		cpu_to_le16(LINK_QUAL_AGG_TIME_LIMIT_DEF);

}



static void *rs_alloc(struct ieee80211_hw *hw, struct dentry *debugfsdir)

drivers/net/wireless/iwlwifi/iwl-commands.h

+12 −0
Original line number Diff line number Diff line
@@ -1913,6 +1913,18 @@ struct iwl_link_qual_general_params { 
	u8 start_rate_index[LINK_QUAL_AC_NUM];

} __attribute__ ((packed));



#define LINK_QUAL_AGG_TIME_LIMIT_DEF	(4000) /* 4 milliseconds */

#define LINK_QUAL_AGG_TIME_LIMIT_MAX	(65535)

#define LINK_QUAL_AGG_TIME_LIMIT_MIN	(0)



#define LINK_QUAL_AGG_DISABLE_START_DEF	(3)

#define LINK_QUAL_AGG_DISABLE_START_MAX	(255)

#define LINK_QUAL_AGG_DISABLE_START_MIN	(0)



#define LINK_QUAL_AGG_FRAME_LIMIT_DEF	(31)

#define LINK_QUAL_AGG_FRAME_LIMIT_MAX	(64)

#define LINK_QUAL_AGG_FRAME_LIMIT_MIN	(0)



/**

 * struct iwl_link_qual_agg_params

 *

drivers/net/wireless/iwlwifi/iwl-sta.c

+3 −2
Original line number Diff line number Diff line
@@ -985,8 +985,9 @@ static void iwl_sta_init_lq(struct iwl_priv *priv, const u8 *addr, bool is_ap) 
	link_cmd.general_params.single_stream_ant_msk =

				first_antenna(priv->hw_params.valid_tx_ant);

	link_cmd.general_params.dual_stream_ant_msk = 3;

	link_cmd.agg_params.agg_dis_start_th = 3;

	link_cmd.agg_params.agg_time_limit = cpu_to_le16(4000);

	link_cmd.agg_params.agg_dis_start_th = LINK_QUAL_AGG_DISABLE_START_DEF;

	link_cmd.agg_params.agg_time_limit =

		cpu_to_le16(LINK_QUAL_AGG_TIME_LIMIT_DEF);



	/* Update the rate scaling for control frame Tx to AP */

	link_cmd.sta_id = is_ap ? IWL_AP_ID : priv->hw_params.bcast_sta_id;