Commit 13b93ed9 authored Jan 10, 2011 by Sony Chacko Committed by David S. Miller Jan 10, 2011

qlcnic: fix ethtool diagnostics test



IRQ diag test was getting executed only when both register test
and link test passed. The test should get executed if ETH_TEST_FL_OFFLINE
flag is set.

Signed-off-by: Sony Chacko <sony.chacko@qlogic.com>
Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 0e5f20b6

drivers/net/qlcnic/qlcnic_ethtool.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -672,7 +672,7 @@ qlcnic_diag_test(struct net_device dev, struct ethtool_test eth_test,
		if (data[1])
		eth_test->flags \|= ETH_TEST_FL_FAILED;

		if (eth_test->flags == ETH_TEST_FL_OFFLINE) {
		if (eth_test->flags & ETH_TEST_FL_OFFLINE) {
		data[2] = qlcnic_irq_test(dev);
		if (data[2])
		eth_test->flags \|= ETH_TEST_FL_FAILED;