Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 121f0994 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jens Axboe
Browse files

bio: change some signed vars to unsigned 



This is just a cleanup patch to silence a static checker warning.

The problem is that we cap "nr_iovecs" so it can't be larger than
"UIO_MAXIOV" but we don't check for negative values.  It turns out this is
prevented at other layers, but logically it doesn't make sense to have
negative nr_iovecs so making it unsigned is nicer.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 3540d5e8

fs/bio.c

+4 −3
Original line number Diff line number Diff line
@@ -337,7 +337,7 @@ static void bio_fs_destructor(struct bio *bio) 
 *	RETURNS:

 *	Pointer to new bio on success, NULL on failure.

 */

struct bio *bio_alloc(gfp_t gfp_mask, int nr_iovecs)

struct bio *bio_alloc(gfp_t gfp_mask, unsigned int nr_iovecs)

{

	struct bio *bio = bio_alloc_bioset(gfp_mask, nr_iovecs, fs_bio_set);
@@ -365,7 +365,7 @@ static void bio_kmalloc_destructor(struct bio *bio) 
 *   %__GFP_WAIT, the allocation is guaranteed to succeed.

 *

 **/

struct bio *bio_kmalloc(gfp_t gfp_mask, int nr_iovecs)

struct bio *bio_kmalloc(gfp_t gfp_mask, unsigned int nr_iovecs)

{

	struct bio *bio;
@@ -696,7 +696,8 @@ static void bio_free_map_data(struct bio_map_data *bmd) 
	kfree(bmd);

}



static struct bio_map_data *bio_alloc_map_data(int nr_segs, int iov_count,

static struct bio_map_data *bio_alloc_map_data(int nr_segs,

					       unsigned int iov_count,

					       gfp_t gfp_mask)

{

	struct bio_map_data *bmd;

include/linux/bio.h

+2 −2
Original line number Diff line number Diff line
@@ -211,8 +211,8 @@ extern void bio_pair_release(struct bio_pair *dbio); 
extern struct bio_set *bioset_create(unsigned int, unsigned int);

extern void bioset_free(struct bio_set *);



extern struct bio *bio_alloc(gfp_t, int);

extern struct bio *bio_kmalloc(gfp_t, int);

extern struct bio *bio_alloc(gfp_t, unsigned int);

extern struct bio *bio_kmalloc(gfp_t, unsigned int);

extern struct bio *bio_alloc_bioset(gfp_t, int, struct bio_set *);

extern void bio_put(struct bio *);

extern void bio_free(struct bio *, struct bio_set *);