Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 10f4b89a authored by Masatake YAMATO's avatar Masatake YAMATO Committed by James Bottomley
Browse files

[SCSI] Fix signness of parameters in scsi module 



In scsi module I've found some inconsistency between variable type
used in module_param_named and type passed to module_param_named as an
argument. Especially the inconsistency of `max_scsi_luns' parameter is
a bit serious because the description text says "last scsi LUN (should
be between 1 and 2^32-1)".

Signed-off-by: default avatarMasatake YAMATO <jet@gyve.org>
Acked-by: default avatarRandy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
parent 427d0bd4

drivers/scsi/scsi_scan.c

+3 −3
Original line number Diff line number Diff line
@@ -85,7 +85,7 @@ static unsigned int max_scsi_luns = MAX_SCSI_LUNS; 
static unsigned int max_scsi_luns = 1;

#endif



module_param_named(max_luns, max_scsi_luns, int, S_IRUGO|S_IWUSR);

module_param_named(max_luns, max_scsi_luns, uint, S_IRUGO|S_IWUSR);

MODULE_PARM_DESC(max_luns,

		 "last scsi LUN (should be between 1 and 2^32-1)");
@@ -109,14 +109,14 @@ MODULE_PARM_DESC(scan, "sync, async or none"); 
 */

static unsigned int max_scsi_report_luns = 511;



module_param_named(max_report_luns, max_scsi_report_luns, int, S_IRUGO|S_IWUSR);

module_param_named(max_report_luns, max_scsi_report_luns, uint, S_IRUGO|S_IWUSR);

MODULE_PARM_DESC(max_report_luns,

		 "REPORT LUNS maximum number of LUNS received (should be"

		 " between 1 and 16384)");



static unsigned int scsi_inq_timeout = SCSI_TIMEOUT/HZ+3;



module_param_named(inq_timeout, scsi_inq_timeout, int, S_IRUGO|S_IWUSR);

module_param_named(inq_timeout, scsi_inq_timeout, uint, S_IRUGO|S_IWUSR);

MODULE_PARM_DESC(inq_timeout, 

		 "Timeout (in seconds) waiting for devices to answer INQUIRY."

		 " Default is 5. Some non-compliant devices need more.");

drivers/scsi/scsi_transport_fc.c

+1 −1
Original line number Diff line number Diff line
@@ -474,7 +474,7 @@ static DECLARE_TRANSPORT_CLASS(fc_vport_class, 
 */

static unsigned int fc_dev_loss_tmo = 60;		/* seconds */



module_param_named(dev_loss_tmo, fc_dev_loss_tmo, int, S_IRUGO|S_IWUSR);

module_param_named(dev_loss_tmo, fc_dev_loss_tmo, uint, S_IRUGO|S_IWUSR);

MODULE_PARM_DESC(dev_loss_tmo,

		 "Maximum number of seconds that the FC transport should"

		 " insulate the loss of a remote port. Once this value is"