Commit 104cbd55 authored Jan 07, 2009 by Lai Jiangshan Committed by Linus Torvalds Jan 08, 2009

cgroups: use task_lock() for access tsk->cgroups safe in cgroup_clone()



Use task_lock() protect tsk->cgroups and get_css_set(tsk->cgroups).

Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Acked-by: Paul Menage <menage@google.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Pavel Emelyanov <xemul@openvz.org>
Cc: Balbir Singh <balbir@in.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent b2aa30f7

kernel/cgroup.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -2903,6 +2903,7 @@ int cgroup_clone(struct task_struct tsk, struct cgroup_subsys subsys,
		mutex_unlock(&cgroup_mutex);
		return 0;
		}
		task_lock(tsk);
		cg = tsk->cgroups;
		parent = task_cgroup(tsk, subsys->subsys_id);

		@@ -2915,6 +2916,7 @@ int cgroup_clone(struct task_struct tsk, struct cgroup_subsys subsys,

		/* Keep the cgroup alive */
		get_css_set(cg);
		task_unlock(tsk);
		mutex_unlock(&cgroup_mutex);

		/* Now do the VFS work to create a cgroup */