Commit 1037246c authored Aug 03, 2010 by Kulikov Vasiliy Committed by Greg Kroah-Hartman Oct 22, 2010

uio: do not use PCI resources before pci_enable_device()



IRQ and resource[] may not have correct values until
after PCI hotplug setup occurs at pci_enable_device() time.

The semantic match that finds this problem is as follows:

// <smpl>
@@
identifier x;
identifier request ~= "pci_request.*|pci_resource.*";
@@

(
* x->irq
|
* x->resource
|
* request(x, ...)
)
 ...
*pci_enable_device(x)
// </smpl>

Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Hans J. Koch <hjk@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent d79d3244

drivers/uio/uio_pci_generic.c

+7 −6

Original line number	Diff line number	Diff line
		@@ -128,12 +128,6 @@ static int __devinit probe(struct pci_dev *pdev,
		struct uio_pci_generic_dev *gdev;
		int err;

		if (!pdev->irq) {
		dev_warn(&pdev->dev, "No IRQ assigned to device: "
		"no support for interrupts?\n");
		return -ENODEV;
		}

		err = pci_enable_device(pdev);
		if (err) {
		dev_err(&pdev->dev, "%s: pci_enable_device failed: %d\n",
		@@ -141,6 +135,13 @@ static int __devinit probe(struct pci_dev *pdev,
		return err;
		}

		if (!pdev->irq) {
		dev_warn(&pdev->dev, "No IRQ assigned to device: "
		"no support for interrupts?\n");
		pci_disable_device(pdev);
		return -ENODEV;
		}

		err = verify_pci_2_3(pdev);
		if (err)
		goto err_verify;