Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1035758d authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

[media] feature_removal_schedule.txt: mark VIDIOC_*_OLD ioctls to die 



There are some old broken definitions of ioctl's, where the
read/write arguments were marked wrong. The last one were added
on 2.6.6 kernel. Remove them, in order to cleanup some
copy_from_user/copy_to_user logic done inside V4L core.

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 0334c8a5

Documentation/feature-removal-schedule.txt

+21 −0
Original line number Diff line number Diff line
@@ -112,6 +112,27 @@ Who: Mauro Carvalho Chehab <mchehab@infradead.org> 


---------------------------



What:	Video4Linux: Remove obsolete ioctl's

When:	kernel 2.6.39

Files:	include/media/videodev2.h

Why:	Some ioctl's were defined wrong on 2.6.2 and 2.6.6, using the wrong

	type of R/W arguments. They were fixed, but the old ioctl names are

	still there, maintained to avoid breaking binary compatibility:

	  #define VIDIOC_OVERLAY_OLD   	_IOWR('V', 14, int)

	  #define VIDIOC_S_PARM_OLD	_IOW('V', 22, struct v4l2_streamparm)

	  #define VIDIOC_S_CTRL_OLD	_IOW('V', 28, struct v4l2_control)

	  #define VIDIOC_G_AUDIO_OLD	_IOWR('V', 33, struct v4l2_audio)

	  #define VIDIOC_G_AUDOUT_OLD	_IOWR('V', 49, struct v4l2_audioout)

	  #define VIDIOC_CROPCAP_OLD	_IOR('V', 58, struct v4l2_cropcap)

	There's no sense on preserving those forever, as it is very doubtful

	that someone would try to use a such old binary with a modern kernel.

	Removing them will allow us to remove some magic done at the V4L ioctl

	handler.



Who:	Mauro Carvalho Chehab <mchehab@infradead.org>



---------------------------



What:	sys_sysctl

When:	September 2010

Option: CONFIG_SYSCTL_SYSCALL