Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0fc86eca authored by Henrik Rydberg's avatar Henrik Rydberg Committed by Guenter Roeck
Browse files

hwmon: (applesmc) Silence uninitialized warnings 



Some error paths do not set a result, leading to the (false)
assumption that the value may be used uninitialized. Set results for
those paths as well.

Signed-off-by: default avatarHenrik Rydberg <rydberg@euromail.se>
Signed-off-by: default avatarGuenter Roeck <guenter.roeck@ericsson.com>
parent 7599d32b

drivers/hwmon/applesmc.c

+6 −2
Original line number Diff line number Diff line
@@ -344,8 +344,10 @@ static int applesmc_get_lower_bound(unsigned int *lo, const char *key) 
	while (begin != end) {

		int middle = begin + (end - begin) / 2;

		entry = applesmc_get_entry_by_index(middle);

		if (IS_ERR(entry))

		if (IS_ERR(entry)) {

			*lo = 0;

			return PTR_ERR(entry);

		}

		if (strcmp(entry->key, key) < 0)

			begin = middle + 1;

		else
@@ -364,8 +366,10 @@ static int applesmc_get_upper_bound(unsigned int *hi, const char *key) 
	while (begin != end) {

		int middle = begin + (end - begin) / 2;

		entry = applesmc_get_entry_by_index(middle);

		if (IS_ERR(entry))

		if (IS_ERR(entry)) {

			*hi = smcreg.key_count;

			return PTR_ERR(entry);

		}

		if (strcmp(key, entry->key) < 0)

			end = middle;

		else