Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0fae8237 authored by Jingoo Han's avatar Jingoo Han Committed by Linus Torvalds
Browse files

rtc: rtc-ds2404: use dev_err() instead of printk() 



Fix the checkpatch warning as below:

  WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...

Signed-off-by: default avatarJingoo Han <jg1.han@samsung.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 34650f9e

drivers/rtc/rtc-ds2404.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -70,7 +70,7 @@ static int ds2404_gpio_map(struct ds2404 *chip, struct platform_device *pdev, 
	for (i = 0; i < ARRAY_SIZE(ds2404_gpio); i++) {

	for (i = 0; i < ARRAY_SIZE(ds2404_gpio); i++) {

		err = gpio_request(ds2404_gpio[i].gpio, ds2404_gpio[i].name);

		err = gpio_request(ds2404_gpio[i].gpio, ds2404_gpio[i].name);

		if (err) {

		if (err) {

			printk(KERN_ERR "error mapping gpio %s: %d\n",

			dev_err(&pdev->dev, "error mapping gpio %s: %d\n",

				ds2404_gpio[i].name, err);

				ds2404_gpio[i].name, err);

			goto err_request;

			goto err_request;

		}

		}
@@ -177,7 +177,7 @@ static void ds2404_write_memory(struct device *dev, u16 offset, 




	for (i = 0; i < length; i++) {

	for (i = 0; i < length; i++) {

		if (out[i] != ds2404_read_byte(dev)) {

		if (out[i] != ds2404_read_byte(dev)) {

			printk(KERN_ERR "read invalid data\n");

			dev_err(dev, "read invalid data\n");

			return;

			return;

		}

		}

	}

	}