Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0f238418 authored by Mike Christie's avatar Mike Christie Committed by James Bottomley
Browse files

[SCSI] iscsi_tcp: print useful error message when iscsi crc23c allocation fails 



People do not read the README and seem to like to
unselect the crc32c module even though iscsi_tcp selects
it for them. This patch spits a error that tells the user
that they really do need the module. Hopefully, we will
get fewer people asking about this now.

Signed-off-by: default avatarMike Christie <michaelc@cs.wisc.edu>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
parent 8231f0ed

drivers/scsi/iscsi_tcp.c

+12 −2
Original line number Diff line number Diff line
@@ -1777,14 +1777,24 @@ iscsi_tcp_conn_create(struct iscsi_cls_session *cls_session, uint32_t conn_idx) 
	tcp_conn->tx_hash.tfm = crypto_alloc_hash("crc32c", 0,

						  CRYPTO_ALG_ASYNC);

	tcp_conn->tx_hash.flags = 0;

	if (IS_ERR(tcp_conn->tx_hash.tfm))

	if (IS_ERR(tcp_conn->tx_hash.tfm)) {

		printk(KERN_ERR "Could not create connection due to crc32c "

		       "loading error %ld. Make sure the crc32c module is "

		       "built as a module or into the kernel\n",

			PTR_ERR(tcp_conn->tx_hash.tfm));

		goto free_tcp_conn;

	}



	tcp_conn->rx_hash.tfm = crypto_alloc_hash("crc32c", 0,

						  CRYPTO_ALG_ASYNC);

	tcp_conn->rx_hash.flags = 0;

	if (IS_ERR(tcp_conn->rx_hash.tfm))

	if (IS_ERR(tcp_conn->rx_hash.tfm)) {

		printk(KERN_ERR "Could not create connection due to crc32c "

		       "loading error %ld. Make sure the crc32c module is "

		       "built as a module or into the kernel\n",

			PTR_ERR(tcp_conn->rx_hash.tfm));

		goto free_tx_tfm;

	}



	return cls_conn;