Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0f22072a authored by Dan Rosenberg's avatar Dan Rosenberg Committed by Russell King
Browse files

ARM: 6891/1: prevent heap corruption in OABI semtimedop 



When CONFIG_OABI_COMPAT is set, the wrapper for semtimedop does not
bound the nsops argument.  A sufficiently large value will cause an
integer overflow in allocation size, followed by copying too much data
into the allocated buffer.  Fix this by restricting nsops to SEMOPM.
Untested.

Cc: stable@kernel.org
Signed-off-by: default avatarDan Rosenberg <drosenberg@vsecurity.com>
Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
parent 408133e9

arch/arm/kernel/sys_oabi-compat.c

+1 −1
Original line number Diff line number Diff line
@@ -311,7 +311,7 @@ asmlinkage long sys_oabi_semtimedop(int semid, 
	long err;

	int i;



	if (nsops < 1)

	if (nsops < 1 || nsops > SEMOPM)

		return -EINVAL;

	sops = kmalloc(sizeof(*sops) * nsops, GFP_KERNEL);

	if (!sops)