Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0f1e54ae authored by Ben Hutchings's avatar Ben Hutchings
Browse files

sfc: Explain why efx_mcdi_exit_assertion() ignores result of efx_mcdi_rpc() 



Fix CID 113952 in Coverity report on Linux.

This is the one instance where we don't, and shouldn't, check the
return code from efx_mcdi_rpc().  It wasn't immediately obvious to me
why we didn't, so I think an explanation is in order.

Signed-off-by: default avatarBen Hutchings <bhutchings@solarflare.com>
parent e3ed2bdf

drivers/net/ethernet/sfc/mcdi.c

+8 −3
Original line number Diff line number Diff line
@@ -1001,11 +1001,16 @@ static void efx_mcdi_exit_assertion(struct efx_nic *efx) 
{

	u8 inbuf[MC_CMD_REBOOT_IN_LEN];



	/* Atomically reboot the mcfw out of the assertion handler */

	/* If the MC is running debug firmware, it might now be

	 * waiting for a debugger to attach, but we just want it to

	 * reboot.  We set a flag that makes the command a no-op if it

	 * has already done so.  We don't know what return code to

	 * expect (0 or -EIO), so ignore it.

	 */

	BUILD_BUG_ON(MC_CMD_REBOOT_OUT_LEN != 0);

	MCDI_SET_DWORD(inbuf, REBOOT_IN_FLAGS,

		       MC_CMD_REBOOT_FLAGS_AFTER_ASSERTION);

	efx_mcdi_rpc(efx, MC_CMD_REBOOT, inbuf, MC_CMD_REBOOT_IN_LEN,

	(void) efx_mcdi_rpc(efx, MC_CMD_REBOOT, inbuf, MC_CMD_REBOOT_IN_LEN,

			    NULL, 0, NULL);

}