Commit 0ebe34f7 authored Mar 28, 2018 by Martijn Coenen Committed by Greg Kroah-Hartman May 11, 2018

UPSTREAM: ANDROID: binder: prevent transactions into own process.



This can't happen with normal nodes (because you can't get a ref
to a node you own), but it could happen with the context manager;
to make the behavior consistent with regular nodes, reject
transactions into the context manager by the process owning it.

Reported-by:  <syzbot+09e05aba06723a94d43d@syzkaller.appspotmail.com>
Signed-off-by: Martijn Coenen <maco@android.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit 7aa135fcf26377f92dc0680a57566b4c7f3e281b)

parent aa40d63c

drivers/staging/android/binder.c

+8 −0

Original line number	Diff line number	Diff line
		@@ -2992,6 +2992,14 @@ static void binder_transaction(struct binder_proc *proc,
		else
		return_error = BR_DEAD_REPLY;
		mutex_unlock(&context->context_mgr_node_lock);
		if (target_node && target_proc == proc) {
		binder_user_error("%d:%d got transaction to context manager from process owning it\n",
		proc->pid, thread->pid);
		return_error = BR_FAILED_REPLY;
		return_error_param = -EINVAL;
		return_error_line = __LINE__;
		goto err_invalid_target_handle;
		}
		}
		if (!target_node) {
		/*