Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0e4b949e authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Marc Kleine-Budde
Browse files

can: flexcan: fix flexcan driver build for big endian on ARM and little endian on PowerPc 



There is no reason to disallow building the driver on big-endian ARM kernels.
Furthermore, the current behavior is actually broken on little-endian PowerPC
as well.

The choice of register accessor functions must purely depend on the CPU
architecture, not which endianess the CPU is running on. Note that we nowadays
allow both big-endian ARM and little-endian PowerPC kernels.

With this patch applied, we will do the right thing in all four combinations.

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Lothar Waßmann <LW@KARO-electronics.de>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent c044dc21

drivers/net/can/Kconfig

+1 −1
Original line number Diff line number Diff line
@@ -104,7 +104,7 @@ config CAN_JANZ_ICAN3 


config CAN_FLEXCAN

	tristate "Support for Freescale FLEXCAN based chips"

	depends on (ARM && CPU_LITTLE_ENDIAN) || PPC

	depends on ARM || PPC

	---help---

	  Say Y here if you want to support for Freescale FlexCAN.

drivers/net/can/flexcan.c

+5 −2
Original line number Diff line number Diff line
@@ -235,9 +235,12 @@ static const struct can_bittiming_const flexcan_bittiming_const = { 
};



/*

 * Abstract off the read/write for arm versus ppc.

 * Abstract off the read/write for arm versus ppc. This

 * assumes that PPC uses big-endian registers and everything

 * else uses little-endian registers, independent of CPU

 * endianess.

 */

#if defined(__BIG_ENDIAN)

#if defined(CONFIG_PPC)

static inline u32 flexcan_read(void __iomem *addr)

{

	return in_be32(addr);