Commit 0d487bc5 authored Jun 06, 2017 by Alexander Potapenko Committed by Greg Kroah-Hartman Jul 05, 2017

net: don't call strlen on non-terminated string in dev_set_alias()




[ Upstream commit c28294b941232931fbd714099798eb7aa7e865d7 ]

KMSAN reported a use of uninitialized memory in dev_set_alias(),
which was caused by calling strlcpy() (which in turn called strlen())
on the user-supplied non-terminated string.

Signed-off-by: Alexander Potapenko <glider@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent dc818ce5

net/core/dev.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1194,8 +1194,9 @@ int dev_set_alias(struct net_device dev, const char alias, size_t len)
		if (!new_ifalias)
		return -ENOMEM;
		dev->ifalias = new_ifalias;
		memcpy(dev->ifalias, alias, len);
		dev->ifalias[len] = 0;

		strlcpy(dev->ifalias, alias, len+1);
		return len;
		}