Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0bf01c3c authored by Jiri Slaby's avatar Jiri Slaby Committed by Jesse Barnes
Browse files

PCI: hotplug/cpcihp, fix pci device refcounting 



Stanse found an ommitted pci_dev_put on one error path in
cpcihp_generic_init. The path is taken on !dev, but also when
dev->hdr_type != PCI_HEADER_TYPE_BRIDGE. However it omits to
pci_dev_put on the latter.

As it is fine to pass NULL to pci_dev_put, put it in there
uncoditionally.

Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
Cc: Scott Murray <scott@spiteful.org>
Signed-off-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>
parent 41a68a74

drivers/pci/hotplug/cpcihp_generic.c

+1 −0
Original line number Diff line number Diff line
@@ -162,6 +162,7 @@ static int __init cpcihp_generic_init(void) 
	dev = pci_get_slot(bus, PCI_DEVFN(bridge_slot, 0));

	if(!dev || dev->hdr_type != PCI_HEADER_TYPE_BRIDGE) {

		err("Invalid bridge device %s", bridge);

		pci_dev_put(dev);

		return -EINVAL;

	}

	bus = dev->subordinate;