Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0beaca2c authored by Ben Hutchings's avatar Ben Hutchings
Browse files

sfc: Remove parentheses around return expressions, reported by checkpatch 



Fix the following error:

ERROR: return is not a function, parentheses are not required

Signed-off-by: default avatarBen Hutchings <bhutchings@solarflare.com>
parent e9e01846

drivers/net/ethernet/sfc/rx.c

+7 −8
Original line number Original line Diff line number Diff line
@@ -98,8 +98,8 @@ static inline unsigned int efx_rx_buf_offset(struct efx_nic *efx, 
	/* Offset is always within one page, so we don't need to consider

	/* Offset is always within one page, so we don't need to consider

	 * the page order.

	 * the page order.

	 */

	 */

	return (((__force unsigned long) buf->dma_addr & (PAGE_SIZE - 1)) +

	return ((__force unsigned long) buf->dma_addr & (PAGE_SIZE - 1)) +

		efx->type->rx_buffer_hash_size);

		efx->type->rx_buffer_hash_size;

}

}

static inline unsigned int efx_rx_buf_size(struct efx_nic *efx)

static inline unsigned int efx_rx_buf_size(struct efx_nic *efx)

{

{
@@ -111,8 +111,7 @@ static u8 *efx_rx_buf_eh(struct efx_nic *efx, struct efx_rx_buffer *buf) 
	if (buf->is_page)

	if (buf->is_page)

		return page_address(buf->u.page) + efx_rx_buf_offset(efx, buf);

		return page_address(buf->u.page) + efx_rx_buf_offset(efx, buf);

	else

	else

		return ((u8 *)buf->u.skb->data +

		return (u8 *)buf->u.skb->data + efx->type->rx_buffer_hash_size;

			efx->type->rx_buffer_hash_size);

}

}





static inline u32 efx_rx_buf_hash(const u8 *eh)

static inline u32 efx_rx_buf_hash(const u8 *eh)
@@ -122,10 +121,10 @@ static inline u32 efx_rx_buf_hash(const u8 *eh) 
	return __le32_to_cpup((const __le32 *)(eh - 4));

	return __le32_to_cpup((const __le32 *)(eh - 4));

#else

#else

	const u8 *data = eh - 4;

	const u8 *data = eh - 4;

	return ((u32)data[0]       |

	return (u32)data[0]	  |

	       (u32)data[1] << 8  |

	       (u32)data[1] << 8  |

	       (u32)data[2] << 16 |

	       (u32)data[2] << 16 |

		(u32)data[3] << 24);

	       (u32)data[3] << 24;

#endif

#endif

}

}