Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0b8b0dca authored by Alex Chiang's avatar Alex Chiang Committed by Jesse Barnes
Browse files

PCI Hotplug: fakephp: add duplicate slot name debugging 



The PCI core now manages slot names on behalf of slot detection
and slot hotplug drivers, including the handling of duplicate
slot names.

We can use the fakephp driver to help test the new functionality.
Add a 'dup_slots' module param to force fakephp to create multiple
slots with the same name. We can then verify that the PCI core
correctly renamed the slots.

	sapphire:/sys/bus/pci/slots # modprobe fakephp dup_slots
	sapphire:/sys/bus/pci/slots # ls
	fake    fake-10  fake-3  fake-5  fake-7  fake-9
	fake-1  fake-2   fake-4  fake-6  fake-8

Cc: kristen.c.accardi@intel.com
Cc: matthew@wil.cx
Acked-by: default avatarKenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: default avatarAlex Chiang <achiang@hp.com>
Signed-off-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>
parent 58319b80

drivers/pci/hotplug/fakephp.c

+8 −2
Original line number Diff line number Diff line
@@ -69,6 +69,7 @@ struct dummy_slot { 
};



static int debug;

static int dup_slots;

static LIST_HEAD(slot_list);

static struct workqueue_struct *dummyphp_wq;
@@ -121,7 +122,11 @@ static int add_slot(struct pci_dev *dev) 
	if (!dslot)

		goto error_info;



	if (dup_slots)

		snprintf(name, SLOT_NAME_SIZE, "fake");

	else

		snprintf(name, SLOT_NAME_SIZE, "fake%d", count++);

	dbg("slot->name = %s\n", name);

	slot->ops = &dummy_hotplug_slot_ops;

	slot->release = &dummy_release;

	slot->private = dslot;
@@ -375,4 +380,5 @@ MODULE_DESCRIPTION(DRIVER_DESC); 
MODULE_LICENSE("GPL");

module_param(debug, bool, S_IRUGO | S_IWUSR);

MODULE_PARM_DESC(debug, "Debugging mode enabled or not");

module_param(dup_slots, bool, S_IRUGO | S_IWUSR);

MODULE_PARM_DESC(dup_slots, "Force duplicate slot names for debugging");