Commit 0b4634fc authored Nov 16, 2009 by Dmitry Eremin-Solenikov Committed by Richard Purdie Nov 16, 2009

leds-gpio: fix possible crash on OF device unbinding

If there are leds present in the OF tree, but the GPIOs for (some) of
them are unavailable, led_data doesn't get populated with correct
devices. Then, on device unbinding, one can crash the kernel.

Workaround this by setting led->gpio to invalid value early.

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Signed-off-by: Richard Purdie <rpurdie@linux.intel.com>

parent 716bdf18

drivers/leds/leds-gpio.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -78,6 +78,8 @@ static int __devinit create_gpio_led(const struct gpio_led *template,
		{
		int ret, state;

		led_dat->gpio = -1;

		/* skip leds that aren't available */
		if (!gpio_is_valid(template->gpio)) {
		printk(KERN_INFO "Skipping unavailable LED gpio %d (%s)\n",