Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0b3fa399 authored by Stefan Achatz's avatar Stefan Achatz Committed by Jiri Kosina
Browse files

HID: roccat: remove obsolete kone_abi_version sysfs attribute 



The newest version of the accompanying userland tools cuts backward
compatibility and uses libudev to find its devices superseding the
quirky kone_abi_version sysfs attribute. Therefore it should be removed.

Signed-off-by: default avatarStefan Achatz <erazor_de@users.sourceforge.net>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent cab6b16a

Documentation/ABI/testing/sysfs-driver-hid-roccat-kone

+0 −12
Original line number Diff line number Diff line
@@ -33,18 +33,6 @@ Description: When read, this file returns the raw integer version number of the 
		left. E.g. a returned value of 138 means 1.38

		This file is readonly.



What:		/sys/bus/usb/devices/<busnum>-<devnum>:<config num>.<interface num>/kone_abi_version

Date:		May 2010

Contact:	Stefan Achatz <erazor_de@users.sourceforge.net>

Description:	When read, this file returns the abi version as an integer value.

		This attribute is used by the userland tools to find the sysfs-

		paths of installed kone-mice and determine the capabilites of

		the driver. Versions of this driver for old kernels replace

		usbhid instead of generic-usb. The way to scan for this file

		has been chosen to provide a consistent way for all supported

		kernel versions.

		This file is readonly.



What:		/sys/bus/usb/devices/<busnum>-<devnum>:<config num>.<interface num>/profile[1-5]

Date:		March 2010

Contact:	Stefan Achatz <erazor_de@users.sourceforge.net>

drivers/hid/hid-roccat-kone.c

+0 −16
Original line number Diff line number Diff line
@@ -617,18 +617,6 @@ static ssize_t kone_sysfs_set_startup_profile(struct device *dev, 
	return size;

}



/*

 * This file is used by userland software to find devices that are handled by

 * this driver. This provides a consistent way for actual and older kernels

 * where this driver replaced usbhid instead of generic-usb.

 * Driver capabilities are determined by returned number.

 */

static ssize_t kone_sysfs_show_abi_version(struct device *dev,

		struct device_attribute *attr, char *buf)

{

	return snprintf(buf, PAGE_SIZE, ROCCAT_KONE_ABI_VERSION "\n");

}



/*

 * Read actual dpi settings.

 * Returns raw value for further processing. Refer to enum kone_polling_rates to
@@ -666,9 +654,6 @@ static DEVICE_ATTR(startup_profile, 0660, 
		kone_sysfs_show_startup_profile,

		kone_sysfs_set_startup_profile);



static DEVICE_ATTR(kone_abi_version, 0440,

		kone_sysfs_show_abi_version, NULL);



static struct attribute *kone_attributes[] = {

		&dev_attr_actual_dpi.attr,

		&dev_attr_actual_profile.attr,
@@ -676,7 +661,6 @@ static struct attribute *kone_attributes[] = { 
		&dev_attr_firmware_version.attr,

		&dev_attr_tcu.attr,

		&dev_attr_startup_profile.attr,

		&dev_attr_kone_abi_version.attr,

		NULL

};

drivers/hid/hid-roccat-kone.h

+0 −2
Original line number Diff line number Diff line
@@ -14,8 +14,6 @@ 


#include <linux/types.h>



#define ROCCAT_KONE_ABI_VERSION "1"



#pragma pack(push)

#pragma pack(1)