Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0aeac458 authored by Magnus Damm's avatar Magnus Damm Committed by Paul Mundt
Browse files

clocksource: sh_tmu: __clocksource_updatefreq_hz() update 



This patch updates the clocksource part of the TMU driver
to make use of the __clocksource_updatefreq_hz() function.

Without this patch the old code uses clocksource_register()
together with a hack that assumes a never changing clock rate
(see clk_enable(), clk_get_rate() and clk_disable()).

The patch uses clocksource_register_hz() with 1 Hz as initial
value, then lets the ->enable() callback update the value
with __clocksource_updatefreq_hz() once the struct clk has
been enabled and the frequency is stable.

Signed-off-by: default avatarMagnus Damm <damm@opensource.se>
Acked-by: default avatarJohn Stultz <johnstul@us.ibm.com>
Signed-off-by: default avatarPaul Mundt <lethal@linux-sh.org>
parent 01fa68b5

drivers/clocksource/sh_tmu.c

+8 −11
Original line number Diff line number Diff line
@@ -199,8 +199,12 @@ static cycle_t sh_tmu_clocksource_read(struct clocksource *cs) 
static int sh_tmu_clocksource_enable(struct clocksource *cs)

{

	struct sh_tmu_priv *p = cs_to_sh_tmu(cs);

	int ret;



	return sh_tmu_enable(p);

	ret = sh_tmu_enable(p);

	if (!ret)

		__clocksource_updatefreq_hz(cs, p->rate);

	return ret;

}



static void sh_tmu_clocksource_disable(struct clocksource *cs)
@@ -221,17 +225,10 @@ static int sh_tmu_register_clocksource(struct sh_tmu_priv *p, 
	cs->mask = CLOCKSOURCE_MASK(32);

	cs->flags = CLOCK_SOURCE_IS_CONTINUOUS;



	/* clk_get_rate() needs an enabled clock */

	clk_enable(p->clk);

	/* channel will be configured at parent clock / 4 */

	p->rate = clk_get_rate(p->clk) / 4;

	clk_disable(p->clk);

	/* TODO: calculate good shift from rate and counter bit width */

	cs->shift = 10;

	cs->mult = clocksource_hz2mult(p->rate, cs->shift);



	dev_info(&p->pdev->dev, "used as clock source\n");

	clocksource_register(cs);



	/* Register with dummy 1 Hz value, gets updated in ->enable() */

	clocksource_register_hz(cs, 1);

	return 0;

}