Commit 0abdc36f authored Dec 22, 2009 by Maulik Mankad Committed by Greg Kroah-Hartman Dec 23, 2009

USB: musb: Fix null pointer dereference issue



This patch fixes the following NULL pointer dereference issue.

Pointer 'request' returned from call to function 'next_request'
at line 748 may be NULL and may be dereferenced at line 792.

============
Code Snippet
============

748:  request = next_request(musb_ep);
785: if (dma && (csr & MUSB_RXCSR_DMAENAB)) {
	csr &= ~(MUSB_RXCSR_AUTOCLEAR
			| MUSB_RXCSR_DMAENAB
			| MUSB_RXCSR_DMAMODE);
	musb_writew(epio, MUSB_RXCSR,
		MUSB_RXCSR_P_WZC_BITS | csr);

792:	 request->actual += musb_ep->dma->actual_len;
		

Signed-off-by: Maulik Mankad <x0082077@ti.com>
Cc: Felipe Balbi <felipe.balbi@nokia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent 796a83fa

drivers/usb/musb/musb_gadget.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -746,6 +746,8 @@ void musb_g_rx(struct musb *musb, u8 epnum)
		musb_ep_select(mbase, epnum);

		request = next_request(musb_ep);
		if (!request)
		return;

		csr = musb_readw(epio, MUSB_RXCSR);
		dma = is_dma_capable() ? musb_ep->dma : NULL;