Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0a6ad06c authored by Tim Gardner's avatar Tim Gardner Committed by Dmitry Torokhov
Browse files

Input: cm109 - convert high volume dev_err() to dev_err_ratelimited() 

BugLink: http://bugs.launchpad.net/bugs/1222850



This input device can get into a state that produces a high
volume of device status errors. Attempt to throttle these
error messages such that the kernel log is not flooded.

Signed-off-by: default avatarTim Gardner <tim.gardner@canonical.com>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent a60a71b0

drivers/input/misc/cm109.c

+10 −4
Original line number Diff line number Diff line
@@ -351,7 +351,9 @@ static void cm109_urb_irq_callback(struct urb *urb) 
	if (status) {

		if (status == -ESHUTDOWN)

			return;

		dev_err(&dev->intf->dev, "%s: urb status %d\n", __func__, status);

		dev_err_ratelimited(&dev->intf->dev, "%s: urb status %d\n",

				    __func__, status);

		goto out;

	}



	/* Special keys */
@@ -418,8 +420,12 @@ static void cm109_urb_ctl_callback(struct urb *urb) 
	     dev->ctl_data->byte[2],

	     dev->ctl_data->byte[3]);



	if (status)

		dev_err(&dev->intf->dev, "%s: urb status %d\n", __func__, status);

	if (status) {

		if (status == -ESHUTDOWN)

			return;

		dev_err_ratelimited(&dev->intf->dev, "%s: urb status %d\n",

				    __func__, status);

	}



	spin_lock(&dev->ctl_submit_lock);
@@ -427,7 +433,7 @@ static void cm109_urb_ctl_callback(struct urb *urb) 


	if (likely(!dev->shutdown)) {



		if (dev->buzzer_pending) {

		if (dev->buzzer_pending || status) {

			dev->buzzer_pending = 0;

			dev->ctl_urb_pending = 1;

			cm109_submit_buzz_toggle(dev);