Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0a4af147 authored by Bjorn Helgaas's avatar Bjorn Helgaas
Browse files

sgi-agp: Use list_for_each_entry() for bus->devices traversal 



Replace list_for_each() + pci_dev_b() with the simpler
list_for_each_entry().

Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Acked-by: default avatarYinghai Lu <yinghai@kernel.org>
CC: David Airlie <airlied@linux.ie>
parent 0b79ca2a

drivers/char/agp/sgi-agp.c

+2 −3
Original line number Original line Diff line number Diff line
@@ -289,12 +289,11 @@ static int __devinit agp_sgi_init(void) 




	j = 0;

	j = 0;

	list_for_each_entry(info, &tioca_list, ca_list) {

	list_for_each_entry(info, &tioca_list, ca_list) {

		struct list_head *tmp;

		if (list_empty(info->ca_devices))

		if (list_empty(info->ca_devices))

			continue;

			continue;

		list_for_each(tmp, info->ca_devices) {

		list_for_each_entry(pdev, info->ca_devices, bus_list) {

			u8 cap_ptr;

			u8 cap_ptr;

			pdev = pci_dev_b(tmp);



			if (pdev->class != (PCI_CLASS_DISPLAY_VGA << 8))

			if (pdev->class != (PCI_CLASS_DISPLAY_VGA << 8))

				continue;

				continue;

			cap_ptr = pci_find_capability(pdev, PCI_CAP_ID_AGP);

			cap_ptr = pci_find_capability(pdev, PCI_CAP_ID_AGP);